Other than my general confusion involving whether filters are still around or not, things looks good. What's below are mostly nits.
api_errors.py: 109-110: I'd be happier with the default values being none, even with the warning there. Maybe a small internal function could be defined that transformed None into the [] and otherwise passed the value through, and apply that function to each argument where it's assigned to the instance variable. image.py: 349: can this line be removed, or is it still used elsewhere? I'll admit I'm not clear on the exact interaction between filters, facets, and variants. Is the first totally replaced by the later two? If so, do we have any way of transforming existing filters into facets+variants so that users don't have to redo their settings? pkgplan.py: 118: can filters be removed from here? 154-155: remove the commented lines, or are we preserving them on purpose? merge.py: 55: should [-v varname ...] be [-v varname,url ...]? Brock Bart Smaalders wrote: > http://cr.opensolaris.org/~barts/FatPkgs/ > 3245 need to support creation of multi-architecture (fat) packages > 5862 gen_actions_by_type isn't filtered, caching breaks filter changes > > Note that some support is there for facets, but the primary focus is > on variants. There will be more coming, but this is needed so that > we can merge sparc and x86 repos. > > - Bart > > > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
