Shawn Walker wrote: <comments not included here accepted>
> line 27: What is the standard we'll be using for locale naming > conventions? I assume whatever one OpenSolaris follows for its own > localisation use? I would think so. > line 43: Should this be s/facet/facet or variant/ ? No. In order to simplify evaluation, I think variant actions should be unique; actions can be repeated if they apply for two out of three variants. This could change if needed. > lines 45-47: Is this saying that if facet.devel=false is set on the > action, but not set in the image, the action will be deselected; or only > when fact.devel=true? > Facets are permissive; if not set in the image to another value then they're accepted. I've added language to that effect. > line 1876: I think we want to reserve -v for verbose for consistency > with other subcommands; using -v for --variant seems problematic. Also, > if they're providing --variant, they've already told us what follows are > variant related, so why force them to say variant.arch=sparc, instead of > just saying arch=sparc? > ok; I've removed the -v and made it --variant only. I've also accepted either --variant variant.arch=sparc or --variant arch=sparc > client/variant.py: > Is this module really client specific? Doesn't it belong under > modules/ instead? I would like to have the web interface present the > effect of variants on a package. Interesting; what about facets & filters as well? - Bart -- Bart Smaalders Solaris Kernel Performance [email protected] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
