Hey,
I am missing the changes to the filelist.py in your webrev.
Probably they should like the ones made in the John's webrev:
http://cr.opensolaris.org/~jmr/pm_webinstall_wip_mar4_540pm/src/modules/client/filelist.py.wdiff.html
best
Michal
Shawn Walker wrote:
jmr wrote:
Hi here is a consolidate webrev using Shawn's Publisher API
(http://cr.opensolaris.org/~swalker/pkg-5871/ ), along with my own
webinstall and repository changes.
You need to install this patch against rev 898:f5eab9e6f812
http://cr.opensolaris.org/~jmr/pm_webinstall_wip_mar4_540pm/
The PM Manage Repositories and Modify work fine allowing you to add
new repos, change mirrors and so on with the new API. If its https
then the appropriate fields are shown in Modify. Changes to URL, SSL
keys and Certs and mirrors apply when clicking Ok on the Modify dialog.
To test the webinstall, just build it and run:
pfexec packagemanager test.p5i <-- adds sunfree2 and contrib
pfexec packagemanager secure.p5i <-- will try to add extra so you can
see the secure repo dialog
When Shawn has a webrev with just the Publisher API changes we can
split out the Webinstaller and Reposiotry gui changes into a separate
gui webrev for review.
Alright, here's my final draft webrev (without gui changes):
http://cr.opensolaris.org/~swalker/pkg-5871
Here's the gui changes (excluding gui/modules/repository.py against the
above webrev):
http://cr.opensolaris.org/~swalker/pkg-5197/
The new api_obj.parse_p5i method will accept either a python file-like
object (has to have read()) or take a location (any valid URI).
This means you can point it at a web address or a file path and it
should "do the right thing."
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
