Michal - I had no performance issues with the consolidated patch I
posted yesterday. The startup time for me after the initial cache
generation was a few seconds max. So perhaps something has changed to
cause a load catalogs in the merge.
You can compare timings by applying my patch from yesterday against 898.
JR
Michal Pryc wrote:
Hello,
I have merged all the gui changes together and posted at:
http://cr.opensolaris.org/~migi/webinstall_v1/
This patch should be applied on top of the:
http://cr.opensolaris.org/~swalker/pkg-5871
(note this webrev is missing filelist.py)
Please do not generate yet another webrev for gui changes as this will
complicate merging. If you want to make changes to the gui, please
grab the http://cr.opensolaris.org/~migi/webinstall_v1/ apply this
patch to the gate, make changes and generate patch only for those.
Now I am planning to play a little bit with this and see what can be
improved as well I am planning to change the parsing function to use
the one provided by the api.
I am not sure why the PM is starting much slower with the new api,
even if this is from cache. Are we calling load_catalogs somewhere in
the api when we shouldn't be doing that?
best
Michal
Shawn Walker wrote:
jmr wrote:
Hi here is a consolidate webrev using Shawn's Publisher API
(http://cr.opensolaris.org/~swalker/pkg-5871/ ), along with my own
webinstall and repository changes.
You need to install this patch against rev 898:f5eab9e6f812
http://cr.opensolaris.org/~jmr/pm_webinstall_wip_mar4_540pm/
The PM Manage Repositories and Modify work fine allowing you to add
new repos, change mirrors and so on with the new API. If its https
then the appropriate fields are shown in Modify. Changes to URL, SSL
keys and Certs and mirrors apply when clicking Ok on the Modify dialog.
To test the webinstall, just build it and run:
pfexec packagemanager test.p5i <-- adds sunfree2 and contrib
pfexec packagemanager secure.p5i <-- will try to add extra so you
can see the secure repo dialog
When Shawn has a webrev with just the Publisher API changes we can
split out the Webinstaller and Reposiotry gui changes into a
separate gui webrev for review.
Alright, here's my final draft webrev (without gui changes):
http://cr.opensolaris.org/~swalker/pkg-5871
Here's the gui changes (excluding gui/modules/repository.py against
the above webrev):
http://cr.opensolaris.org/~swalker/pkg-5197/
The new api_obj.parse_p5i method will accept either a python
file-like object (has to have read()) or take a location (any valid
URI).
This means you can point it at a web address or a file path and it
should "do the right thing."
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
