[email protected] wrote:
Folks,
At Wednesday's iteam meeting, we discussed the need to make sure that
Manifests were written to a tempfile and then renamed into place. This
is a mechanism for making sure that updates to files are atomic -- we
don't want a partially completed file to get written into the file's
final location on the filesystem. This leads to corruption problems.
The per-action manifest indexes are already written this way; however,
there are a number of other places in the code that need to be changed
to do this.
I found some additional bugs with the catalog and updatelog locking
along the way, and fixed a couple of other random minor CLI issues.
http://cr.opensolaris.org/~johansen/webrev-3828/
The webrev is not enormous (< 400 lines), but it's not tiny either.
Comments appreciated.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
catalog.py:
Lines 280-299: I like the reorganization here. One thing I notice is
that if an exception is raised (as on line 287), the files don't seem to
be closed correctly. Also, you could remove the file removal on line 286
since that'll happen in the except block anyway.
updatelog.py:
I don't really understand all of what's going on here from a use
perspective, but I didn't see anything in the code which I thought was
wrong.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
