On Fri, Apr 17, 2009 at 03:42:16PM -0700, Danek Duvall wrote: > On Fri, Apr 17, 2009 at 02:27:56PM -0700, [email protected] wrote: > > > http://cr.opensolaris.org/~johansen/webrev-3828/ > > catalog.py: > > - line 248: I'd call this __append_to_catalog() or __write_entry() or > something; the point of this method isn't to write out the catalog > (though it does so), but to add an entry to the catalog. Since it's > not used by anything outside the class, you can use the > double-underscore to hide it.
Ok. > - line 891: double quotes Ok. > manifest.py: > > - line 457: portable.remove()? That was my initial instinct, but none of the other code in this module uses portable.remove. I kept os.remove, just to keep things consistent. Do you want me to convert all of these to portable.remove? > updatelog.py: > > - similar comments as for catalog.py Ok, thanks. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
