On Fri, Apr 17, 2009 at 02:59:16PM -0700, Brock Pytlik wrote: > [email protected] wrote: >> http://cr.opensolaris.org/~johansen/webrev-3828/ >> > catalog.py: > Lines 280-299: I like the reorganization here. One thing I notice is > that if an exception is raised (as on line 287), the files don't seem to > be closed correctly. Also, you could remove the file removal on line 286 > since that'll happen in the except block anyway.
Thanks. I'll remove line 286. The files should get closed when the objects are deleted. This ought to occur when the variables go out of scope, after the routine completes. I thought that trying to explicitly close the file handles in all of the error cases made the code unnecessarily complicated. Unless I'm missing something, the files should get closed; whereas it's always the responsibility of mkstemp's caller to cleanup tempfiles. > updatelog.py: > I don't really understand all of what's going on here from a use > perspective, but I didn't see anything in the code which I thought was > wrong. This is the mechanism that allows us to provide incremental catalog updates to the catalog/0. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
