On Fri, Apr 17, 2009 at 03:51:09PM -0700, Danek Duvall wrote: > On Fri, Apr 17, 2009 at 03:43:58PM -0700, [email protected] wrote: > > > > manifest.py: > > > > > > - line 457: portable.remove()? > > > > That was my initial instinct, but none of the other code in this module > > uses portable.remove. I kept os.remove, just to keep things consistent. > > Do you want me to convert all of these to portable.remove? > > I don't really care too much whether you leave it as is, change all of > them, or change just this one. Flip a coin. Or, um, roll dice. :)
I've pushed a new copy of the webrev. It contains fixes from your feedback and Brock's feedback. http://cr.opensolaris.org/~johansen/webrev-3828/ I'll push this soon, unless someone else wants to review. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
