Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-arc/
on-disk-format.txt:
- line 685: "envelop" -> "envelope"
attach:
- line 180: two spaces before "[["
client.py:
- line 177ff: what are the empty strings for? Is this to cause blank
lines in the full usage output?
- line 1420: This originates from changeset 50. Any reason to keep it
around?
- line 2468: is this XXX comment now taken care of?
- (formerly line 2482): why get rid of this usage nit?
api.py:
- Would defining _LockedGenerator and _LockedCancelable inside
ImageInterface prevent you from having to un-hide __img and the others?
- line 1457: "tepmorary" -> "temporary"
- line 1504: garbled grammar
- line 1617: no need for [].
- line 1897: "seperation" -> "separation"
- line 2407: is there any point in setting pub, name, and version here
anymore?
image.py:
- line 1639: probably look better if you do "if not ...: return" and
dedent the rest of the method.
- line 2258: "in the known"? "in the 'known' part"?
p5p.py:
- line 45: This is never used. Are you missing something from the
ArchiveIndex class? I thought it odd to have an offsets() method, but
not something that just returned IndexEntry objects while iterating
over an ArchiveIndex object.
- line 160: use "is"
- line 177: this is never set to True, AFAICT. Perhaps at the end of
this method?
- line 502: why doesn't add() add to __processed_pfiles, too?
- line 506, et al: is the :2 an artifact of V1Layout?
- line 1041: reverse the sense of the conditional and dedent the rest of
the method.
repo.py:
- should get_publisherinfo() catch UnknownArchiveFiles, too?
server/transaction.py:
- what's this change?
pull.py:
- line 94: "Store the retrieved package data ..."?
- line 277: space before backslash
- line 404: why not maintain alphabetical order?
t_p5p.py:
- test_05_invalid(): some other suggestions:
- archive that's not a tar file at all (simple text file or ELF file or
something)
- archive whose last file is shorter than than expected
- archive whose offsets are wrong
- archive with a corrupt index: doesn't decompress, wrong format
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
