Shawn Walker wrote: > On 02/ 7/11 05:08 PM, Danek Duvall wrote: > >Shawn Walker wrote: > > > >> http://cr.opensolaris.org/~swalker/pkg-arc/ > > >p5p.py: > > > > - line 502: why doesn't add() add to __processed_pfiles, too? > > Because I wanted consumers of add() to be responsible for dealing > with duplicates since they're providing explicit files to add.
But any consumers outside the class won't be able to do that, because __processed_pfiles is private. Or are you suggesting that external consumers would use a separate accounting? Either way, you might make a note in add()'s docstring. > >repo.py: > > > > - should get_publisherinfo() catch UnknownArchiveFiles, too? > > It catches anything that's an Exception, so it's already handling that. It does, but unlike all the other methods here (like get_datastream()), it doesn't treat it differently. > >t_p5p.py: > > > > - test_05_invalid(): some other suggestions: > > > ... > > - archive whose offsets are wrong > > Archive with an index file that has offsets that don't match the > archive contents? I believe that's what I was going for. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
