On 02/ 8/11 02:06 PM, Danek Duvall wrote:
Shawn Walker wrote:
On 02/ 7/11 05:08 PM, Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-arc/
p5p.py:
- line 502: why doesn't add() add to __processed_pfiles, too?
Because I wanted consumers of add() to be responsible for dealing
with duplicates since they're providing explicit files to add.
But any consumers outside the class won't be able to do that, because
__processed_pfiles is private. Or are you suggesting that external
consumers would use a separate accounting? Either way, you might make a
note in add()'s docstring.
I'm assuming external consumers would use separate accounting.
Technically, the tar format allows multiple entries for the same
pathname; it doesn't matter since it's a streaming format. But it's
highly unlikely that you wanted duplicate entries.
I've updated the docstring.
repo.py:
- should get_publisherinfo() catch UnknownArchiveFiles, too?
It catches anything that's an Exception, so it's already handling that.
It does, but unlike all the other methods here (like get_datastream()), it
doesn't treat it differently.
The difference is that with get_publisherinfo(), you're not asking for a
specific file. It's more of a "you get everything or it failed". All
of the other functions are retrieving specific content.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
