On 02/ 7/11 05:08 PM, Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-arc/
Fixed items elided from reply.
client.py:
- line 177ff: what are the empty strings for? Is this to cause blank
lines in the full usage output?
Correct.
- (formerly line 2482): why get rid of this usage nit?
Because there's no -l option for this subcommand :-)
api.py:
- Would defining _LockedGenerator and _LockedCancelable inside
ImageInterface prevent you from having to un-hide __img and the others?
No; due to Python's name mangling, '__' always transforms to
_<CurrentClass>__<attribute_name> even for nested class definitions. So
it would transform it to '_LockedGenerator__img'.
p5p.py:
- line 45: This is never used. Are you missing something from the
ArchiveIndex class? I thought it odd to have an offsets() method, but
not something that just returned IndexEntry objects while iterating
over an ArchiveIndex object.
I had a number of methods I had written that I ended up not needing
anywhere. So, I nuked them since they weren't used, but failed to
discard the namedtuple.
I figure if we need more later, I'll add it. Right now, this is all
that's needed.
- line 502: why doesn't add() add to __processed_pfiles, too?
Because I wanted consumers of add() to be responsible for dealing with
duplicates since they're providing explicit files to add.
This is in contrast to the other methods where duplicates are expected
since the caller is just asking to add a package, so the same certs,
publisher directories, etc. may be shared.
- line 506, et al: is the :2 an artifact of V1Layout?
If by that you mean, "is this encoding special knowledge of file layout
into the archive": yes.
repo.py:
- should get_publisherinfo() catch UnknownArchiveFiles, too?
It catches anything that's an Exception, so it's already handling that.
server/transaction.py:
- what's this change?
17761 repository append operation erroneously includes append file when
closing transaction
t_p5p.py:
- test_05_invalid(): some other suggestions:
...
- archive whose offsets are wrong
Archive with an index file that has offsets that don't match the archive
contents?
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
