On 06/23/11 17:08, Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-18441-v2/
I've looked over the bits related to the comments I made before, as I
didn't want to do a complete re-review.
One thing I completely forgot about before is that the IFO column in pkg
list can now have its F filled in.
pkg.1.txt:
- line 645: it doesn't change the version of the package installed on the
system, though, does it?
No.
- line 648: no need for two blank lines.
oops.
- line 1244: might be useful to have a second line showing the output of
"pkg freeze" after this.
sure
- line 1249: This is supposed to have output, no?
Yeah. I was just following the examples the other examples set where
they show a command but not output. If you'd like output, I'll add it to
the freeze examples.
- line 1251: I don't know that this demonstrates anything interesting.
Well, I feel that way about many of our examples in general, especially
for something like freeze.. However, if we're going to have "freeze"
examples, then having at least one "unfreeze" example makes sense to me.
client.py:
- line 2250ff: I'd use "NAME", "VERSION", and "DATE"; our column headers
are generally one-word, and where they're not, it's probably a bug.
Ok.
- line 2257ff: This is all to not print the build version, right?
Assuming you mean 2257-2260, then yes.
Thanks for looking again.
Brock
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
