On 06/28/11 01:03 PM, Brock Pytlik wrote:
On 06/28/11 11:17 AM, Shawn Walker wrote:
On 06/24/11 18:12, Brock Pytlik wrote:
New webrev:
http://cr.opensolaris.org/~bpytlik/ips-18441-v3/
Diff from v2 to v3:
http://cr.opensolaris.org/~bpytlik/ips-18441-v2-v3.diff
This addresses the comments Danek had, and fills in the F field of the
IFO in pkg list (which is why I sent this out once more).
src/client.py:
you need to update info() to display "Frozen" just was it already
handles OBSOLETE and RENAMED
src/modules/client/api.py:
The check in get_pkg_list() should just be looking for
PKG_STATE_FROZEN in the package metadata 'states'. You should
be setting PKG_STATE_FROZEN in Image.__rebuild_image_catalogs,
that way consumers can get a simple, fast check of frozen state.
That does mean that __rebuild_image_catalogs will need to be called
anytime freezes change though.
-Shawn
Ok, guess I'll go off and make these changes then. Another webrev will
be coming when it's done.
I don't really see why it makes sense to have to keep the frozen state
in two locations, but if that's what you think should be done, sure,
it can be done. As a side note, I sincerely doubt the current
implementation suffers from much of a performance penalty.
So, looking at info, I disagree that Frozen should go into the same slot
as either obsolete or renamed. A package could be frozen and obsolete or
frozen and renamed.
My inclination would be to simply not include this in pkg info. If
someone believes it has to be there (in which case I would ask why avoid
isn't there), then it needs its own section. Preliminarily, I suggest
putting as an addition ()'d entry. So the line might look like
"Installed (Renamed) (Frozen)" or "Not Installed (Obsolete) (Frozen)" or
"Installed (Frozen)".
Brock
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
