Hi Danek, Thank you for the review.
On 2012年06月20日 02:39, Danek Duvall wrote: :
Both look fine to me. I'd like to see 7122826 moved to solaris/pkg/gui, since that's where we've been keeping the other l10n bugs, though if you generally want to have these bugs in solaris/sysadmin/l10n, that's fine; I just want it consistent.
I've moved it to solaris/pkg/gui. In case we want to move l10n bugs to other category (consistently) in the future, I will consult with you.
In the future, could you make the second "webrev" in unified diff format, rather than normal diff format? Much easier to read for me.
I used normal diff there expecting some people want to see actual changes condensed, but if diff -u is better I can easily switch to it next time. Thanks for the feedback. Besides it, I want to find way to use gdiff -I in webrev so the 2nd and 3rd ones will be consolidated into one. Thanks, Takeshi _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
