Hi José, ah, well, personally I detest this type of magic, it means I have to remember all these little facts, but it means that your patch ought to be applicable as is. I will see to it.
Regards, Arjen On 2010-12-23 13:39, José Luis García Pallero wrote: > El día 23 de diciembre de 2010 13:35, Arjen Markus > <arjen.mar...@deltares.nl> escribió: >> Hi José, >> >> at a first glance this patch (and the one for plgradient) seems okay. >> Only one tiny thing: I am not sure free() can be used with a NULL >> argument. So, I'd say you have to guard against that. (If no one >> picks this up, I will) > > Hello, > Here: http://linux.die.net/man/3/free says > > "free(ptr) has already been called before, undefined behaviour occurs. > If ptr is NULL, no operation is performed. " > > I ever check the multiple malloc() returns in this way, following the > man page of free() > > Thanks for your time checking the patches. > DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail. ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
