El día 30 de diciembre de 2010 09:04, Arjen Markus <arjen.mar...@deltares.nl> escribió: > Hello, > > I have finished the work on the source files that use PL_MAXPOLY > sized arrays. All now use either the statically defined arrays or > allocated arrays if needed. > > I wonder about one file though: xfig.c. One function in this driver > checked the number of points, but it gets passed an array with all > the data in there already. Is it that the xfig format does not > allow polygons of more than 256 points? (I never use that format > and I am unfamiliar with its capabilities and limitations). > In any case I have removed the check. > > I will run the code through the comprehensive test script before > committing, but my system does not do anything with xwin.c, tkwin.c > or plr.c, so there may be syntax errors in there. > > Also, none of the examples really use large polygons, so the > new parts of the patch will formally go untested. > > Regards, > > Arjen
Hello, Thanks for your job. I hope the new features will be useful to someone as for me. Two minor question: 1. Could my name and email appear in the patched files as a contributor (not in copyright owners list, of course -my contribution was so small-)? In the sent patches for plfill.c, plgradient.c, tkwin.c and xwin.c I put my name and a brief of my contribution, but I don't know if this is the correct way to do that. I would like to put my contribution in my (small) CV. 2. In my patch for plfill.c I changed the comments at the start of plfill() and plfill3() to: // Pattern fills the polygon bounded by the input points. -// If hardware fill is used, a maximum of PL_MAXPOLY-1 vertices is allowed. +// For a number of vertices greater than PL_MAXPOLY - 1, memory is managed via +// malloc/free. Otherwise static arrays of length PL_MAXPOLY are used // The final point is explicitly added if it doesn't match up to the first, // to prevent clipping problems. But in the new code of the svn I don't see that. I think that are informative lines of the new behavior. Don't you think the same? Thanks -- ***************************************** José Luis García Pallero jgpall...@gmail.com (o< / / \ V_/_ Use Debian GNU/Linux and enjoy! ***************************************** ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
