Hello, I have finished the work on the source files that use PL_MAXPOLY sized arrays. All now use either the statically defined arrays or allocated arrays if needed.
I wonder about one file though: xfig.c. One function in this driver checked the number of points, but it gets passed an array with all the data in there already. Is it that the xfig format does not allow polygons of more than 256 points? (I never use that format and I am unfamiliar with its capabilities and limitations). In any case I have removed the check. I will run the code through the comprehensive test script before committing, but my system does not do anything with xwin.c, tkwin.c or plr.c, so there may be syntax errors in there. Also, none of the examples really use large polygons, so the new parts of the patch will formally go untested. Regards, Arjen On 2010-12-24 09:05, Arjen Markus wrote: > Hi José, > > I examined these files as well: > Some functions would simply return on encountering a large polygon > and other (several in plbuf.c for instance) would just happily > crash the program. > > I have implemented a patch for plbuf.c and plot3d.c, but I have not > tested them yet, so I want to take some more time. I may get around > to do the rest next week, but certainly not this Christmas weekend. > > I will pick up the patches for xwin.c and tkwin.c, so the remaining > files to be patched are: > - plr.c > - xfig.c > - plrender.c > > (plarc.c does not take arbitrary size polygons, merely uses the macro > PL_MAXPOLY, and plline.c splits up a large polyline in pieces). > > There was a nasty little gotcha in c_plfill3: the vertices are > filtered, so that the value of n may be altered. Fixed that in my > applying the patch. > > Regards, > > Arjen > > On 2010-12-24 00:16, José Luis García Pallero wrote: >> Hello again, >> Attached I send patches for trunk/drivers/tkwin.c and trunk/drivers/xwin.c >> I searched in trunk folder from svn repo ad I found this files >> containing PL_MAXPOLY: >> >> trunk/bindings/tk/plr.c >> trunk/drivers/tkwin.c >> trunk/drivers/xfig.c >> trunk/drivers/xwin.c >> trunk/src/plarc.c >> trunk/src/plbuf.c >> trunk/src/plfill.c >> trunk/src/plgradient.c >> trunk/src/plline.c >> trunk/src/plot3d.c >> trunk/utils/plrender.c >> >> but only plfill, plgradient, tkwin and xwin contains exits if the >> number of elements is greater than PL_MAXPOLY (I don't konw in deep >> the code of PLPlot) >> >> Cheers >> > > > DISCLAIMER: This message is intended exclusively for the addressee(s) and may > contain confidential and privileged information. If you are not the intended > recipient please notify the sender immediately and destroy this message. > Unauthorized use, disclosure or copying of this message is strictly > prohibited. > The foundation 'Stichting Deltares', which has its seat at Delft, The > Netherlands, Commercial Registration Number 41146461, is not liable in any > way whatsoever for consequences and/or damages resulting from the improper, > incomplete and untimely dispatch, receipt and/or content of this e-mail. > > > > > > ------------------------------------------------------------------------------ > Learn how Oracle Real Application Clusters (RAC) One Node allows customers > to consolidate database storage, standardize their database environment, and, > should the need arise, upgrade to a full multi-node Oracle RAC database > without downtime or disruption > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > Plplot-devel mailing list > Plplot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/plplot-devel > DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail. ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
