Hi Arjen: On 2014-09-08 07:39-0000 Arjen Markus wrote:
> Hm, I can not find the function islen() in the current source code. It disappeared in SVN-revision 12099. He must have been looking at a pretty old version. I also did a regex search for integer*4 anywhere in bindings/f95/* and could not find any instances. So please change the status of this patch from open to closed-fixed to help keep our patch-tracker clean. The way you change status of patches at SF is hit the edit button (which should be available to you as a PLplot developer when you login to SF). Please let me know if you have any difficulty with this status change. > I will check the source code for leftovers from the old days (integer*4 and friends are a widespread extension that is completely superfluous and clumsy since the introduction of kinds some 20 years ago). This is a separate but most interesting topic. I think we should follow what we do for plflt and plunicode for the indefinite integer and logical types that currently appear in our Fortran code. That is, add integer, parameter :: plint = 4 integer, parameter :: plbool = 4 to bindings/f95/plflt.inc.in, and replace all instances of integer in our Fortran code with integer(kind=plint) and all instances of logical in our Fortran code with integer(kind=plbool). This change might obviously be a really important issue for those using PLplot in legacy mode like Donald Spong, if such users would have to retype all their integer types that were used for PLplot subroutine arguments. But I don't think that has been an issue for the floating-point types and simply inserting "use plplot" in legacy code normally covers all such issues other than actual backwards-incompatible API changes that have occurred for some of our routines. If you confirm there are no additional legacy issues introduced by the above change, and assuming you like the change in general, I would be willing to do the large amount of editing that would be required since that can be done automatically with sed. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ Plplot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/plplot-devel
