On 2014-11-14 22:52-0000 phil rosenberg wrote: > The problem with not building at all was a check for Linux or Cygwin in docbook.cmake. It used to be a check for Linux, at some point I changed this to Linux or Cygwin but it never worked and I couldn't work out why so I removed it - somehow it has crept back in. I've reremoved it. As Alan said at some point, only devs ever build the documentation anyway and actually it is probably better to get a build error on an unsupported platform then get a silent fail.
Hi Phil: Good catch on this error I reintroduced. My apologies about that (especially to Arjen he must have got a bit of a shock when everything quit working.) I put that logic back in to deal with a warning about inconsistent if and endif statements. The endif logic (which I reinstated for the if) looked fine to me, but you are right; that if logic you just removed was bad. The issue is the logic fragment CMAKE_SYSTEM_NAME STREQUAL "CYGWIN" would fail on Cygwin since that variable is likely set to something else than "CYGWIN" (likely "Windows", see <http://www.cmake.org/cmake/help/v3.0/variable/CMAKE_SYSTEM_NAME.html>) on the Cygwin platform. The test that should be used instead for the Cygwin platform is the truth of the CMake variable CYGWIN. However, I also agree with your further point that we should not put artificial limits on what platforms are allowed to attempt to build the documentation. So your commit was fine with me except that it needed some further logic cleanups (drop redundant parentheses, make endif argument agree with if argument [this time by trusting the if logic!]) which I have done in commit a97319e. Without that commit, you will constantly get warnings about the inconsistent if and endif arguments. > I have checked your fix Alan and the documentation builds first time now so I have removed the warning in the README. Excellent news indeed! I think that success means we are almost done with this thread (at least until Cygwin gets their TeX font installation straightened out). The only remaining question (as far as I know) is whether you guys can get "make validate" to work both with -DBUILD_DOC=ON and OFF. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
