On Thu, Dec 04, 2008 at 11:30:57PM +0100, Juliusz Chroboczek wrote:
Hi,
sorry to reply so late, the message got stuck in some filter and only
resurfaced now.
> > A second thing, I have successfully applied my tunneling patches to this
> > version of polipo. Works perfectly - any chance to integrate this to
> > polipo?
>
> Yes, this is definitely a feature I want to include.
:)
> > +tunnelIsMatched(char *url, int lurl, char *hostname, int lhost)
> There's a buffer overflow in this function -- you need to test that
> lurl >= domain->domain.
should be fixed now.
> Oh, and please use four spaces for indenting. If you're using Emacs, add
> the following to your .emacs, and make sure to ``M-x polipo-c-mode''
> whenever you visit my code:
>
> (defun polipo-c-mode ()
> "C mode adjust for Juliusz's silly taste."
> (interactive)
> (c-mode)
> (setq c-basic-offset 4))
sure, and since I have a few cases like this I have added it to all
other variants to be fired up automatically:
(setq auto-mode-alist (cons '(".*/polipo-.*/.*\\.[ch]$" . polipo-c-mode)
auto-mode-alist))
> The rest of the patch I oppose -- I don't think that keeping a list in
> memory is a good way to implement logging. It uselessly bloats Polipo and
> uses extra memory even when people don't need this functionality. Remember
> that people are using Polipo on OpenWRT systems with 16MB of memory.
>
> Please define a new log level, say LOG_TUNNEL, and log every tunnel using
> do_log(LOG_TUNNEL, ...). Grep for ``L_UNCACHABLE'' for an example.
In principle I like this approach very well. However is one logging level
enough? Sometimes it is useful to have both blocked and allowed connections
logged but in some situations it may be an overkill and waste of resources.
Also, for some reason which I have not yet debugged every blocked connection
appears twice in the logs.. not tested if it is browser oddity yet.
Will send code and docs patches as separate emails after some more testing.
> Oh, and any chance you could send Darcs patches? Trust me, you'll find it
> *much* easier than working with diff/patch by hand.
no darcs at the moment - and I do not do diff/patch by hand.
Richard
------------------------------------------------------------------------------
_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users
