On 08:31 Fri 14 Feb 2025, Thomas Stüfe wrote: > > - the bigger issue to me is the amount of large ifdef sections added to > os/bsd and bsd/<arch> : I think its time to separate MacOS from BSD and > make both first-class OSes. The amount of duplicate coding would be > outweighed by clearer code. Up for discussion, of course; that is just my > gut feeling right now. >
+1 A cursory glance through the PR suggested to me that there is as much a case for the BSD port sharing a directory with Linux as there is MacOS, given the number of cases I saw where it was added to Linux #ifdefs. All the UNIX-based ports (currently everything bar Windows) are always going to share a degree of overlap, something we recognised on the JDK side when the 'unix' subdirectory was added (most of which still lives under 'solaris' in 8u and earlier). If *BSD is going to be maintained upstream, it should have its own directory distinct from MacOS. Another positive of this is that any *BSD changes then only affect that port and don't risk MacOS breakage. Of course, equally, that does mean the *BSD port will no longer get free updates which apply to MacOS. Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew
signature.asc
Description: PGP signature
