On Wed, Jul 26, 2017 at 02:23:18PM -0500, attila wrote:
>
> Stuart Henderson <s...@spacehopper.org> writes:
>
> > On 2017/07/26 16:30, George Rosamond wrote:
> >> Stuart Henderson:
> >> > On 2017/07/26 15:22, Marc Espie wrote:
> >> >> Good news, the update builds with clang... so that's a go for me.
> >> >>
> >> >
> >> > It builds and runs for me, I don't see any problems with toolbars
> >> > (admittedly only light use).
> >>
> >> The issue is related to the bookmarks toolbar, which shows the default
> >> Firefox ones instead of the default TB ones. It's not displayed by
> >> default.
> >
> > This is what I see if I enable it: https://junkpile.org/tb702.png
> > I've never used tor-browser before to know if that's what is expected or
> > not. It's not using bookmarks from my normal Firefox installation but
> > I'm not sure if that's what you mean..
> >
> > Is this very bad? (The other option will be "no package" as the old version
> > isn't going to build).
>
> It is disturbing and annoying because I just can't suss out why it
> started happening. Also, it didn't happen to me in my testing, but my
> only viable method of testing ATM is to use X11 forwarding over SSH on
> a crappy net. When I fire up tor-browser this way on the machine in
> NYC that I work on, I don't get that toolbar, which is how TB normally
> looks.
>
> I cannot explain this yet. It's seriously bugging me. If anyone has
> any clues I'd love to hear them.
>
> That much said it seems clear we should get the update in if possible
> and worry about these details later.
>
> >> > I do see a crash if I try to view certificate information on an HTTPS
> >> > site, but I think it's probably better to commit the update and then try
> >> > to track that down afterwards. (I haven't tested the old version to see
> >> > if it's new, and I'm on a machine with full clang-built packages so it's
> >> > hard to go back and try it now). Unless there are objections I'll go
> >> > ahead and do that.
> >> >
> >>
> >> I'm not seeing that after checking a few different certs.
> >
> > Ok I'm thinking let's ignore that for now..
>
> In the interests of forward progress I'm attaching an updated update
> that addresses the following:
>
> * PATCHORIG
> * remove post-extract search-and-destroy
> * mung WANTLIB/LIB_DEPENDS as per sthen@ (port-lib-depends-check
> seems happy)
> * go back to files/configure, ditch the two configure.in patches
>
> Thanks for all the feedback. Am always open to more.
One thing - you comment out --disable-webrtc, but i suppose/hope for you
TBB explicitely disables it, otherwise all the users caring about their
privacy will be *very* vocal about webrtc leaking their private nat ip
etc. You should check that carefully...
As for files/configure, i get it that its a straight copy from mozilla
upstream, but seeing python2.7 like this makes me cringe. Why not
writing your own script with ${MODPY_BIN} directly calling $(dirname
$0)/configure.py "$@" ? (and exporting OLD_CONFIGURE) - your call.
