On 2017/07/26 22:05, Landry Breuil wrote:
> One thing - you comment out --disable-webrtc, but i suppose/hope for you
> TBB explicitely disables it, otherwise all the users caring about their
> privacy will be *very* vocal about webrtc leaking their private nat ip
> etc. You should check that carefully...
I don't get any addresses reported in the usual webrtc testers.
Though yes I do think it may be a good idea to force this configure flag.
> As for files/configure, i get it that its a straight copy from mozilla
> upstream, but seeing python2.7 like this makes me cringe. Why not
> writing your own script with ${MODPY_BIN} directly calling $(dirname
> $0)/configure.py "$@" ? (and exporting OLD_CONFIGURE) - your call.
I'd prefer that too.
I've committed what we have so far - these are valid points but I think
not critical, and it's much easier to test/review small diffs for these
changes than small changes to a monster diff :)
