On Tue, Apr 10, 2018 at 09:20:37PM -0700, Thomas Frohwein wrote: > Please find attached a port of Godot. Godot, "The Game Engine You Waited For" > (semi-official subtitle), is a professional-grade game development framework > and game engine, capable of designing 2D, as well as 3D games. It is most > commonly compared to Unity. It features its own GDScript language for the > scripting aspect of the development, but also offers interfaces for C++ or > Visual Script (using blocks and connections). Have you asked upstream to provide stable release assets?
I couldn't find an issue or pull request referencing the clang 6 fixes in patches/patch-scene_gui_rich_text_label_cpp, current HEAD doesn't have them either. Can you bring up this issue upstream as well? > It works well on testing with a tutorial 2D game, as well as when running the > 3D demo 'Martinique' (https://github.com/w84death/Martinique). > > A few notes on the port: > - C# support: this is advertised by upstream (done via mono), but FreeBSD's > port describes it as unstable. I left it out for now; may add it in future > update. Sounds reasonable. > - The previously described "crashy" state (on the openbsd-wip repo) was likely > due to the failing to find its own path when entering the main interface. > The > post-extract target fixes that with a hard-coded location of the binary. I > have not observed any unstability or crashing when using Godot. Can you please patch drivers/unix/os_unix.cpp and SUBST_CMD it in post-patch? sed(1) might be the tool if you cannot avoid massive editing and want to avoid tons of patches for that, but in general I'd like to stop editing sources in place. > - In order to build with clang, it needs the use_llvm flag. I moved this into > a > .if ${PROPERTIES:Mclang} to give non-clang arches a chance. Yup. http://docs.godotengine.org/en/latest/development/compiling/compiling_for_x11.html says "Python 2.7+ (Python 3 only supported as of SCons 3.0)", our devel/scons is at 2.5.1, so you should set MODPY_VERSION accordingly. CC, CFLAGS and DEBUG need handling, they're currently ignored. scons has full support for out-of-tree builds and ports as big as Godot will benefit from it, can you look into enabling SEPARATE_BUILD? See http://www.scons.org/doc/2.5.0/HTML/scons-user/ch15.html .
