On Sun, Apr 22, 2018 at 09:29:28AM -0700, tfrohwein wrote: > > Have you asked upstream to provide stable release assets? > > https://github.com/godotengine/godot/issues/18347 > > > I couldn't find an issue or pull request referencing the clang 6 fixes > > in patches/patch-scene_gui_rich_text_label_cpp, current HEAD doesn't > > have them either. Can you bring up this issue upstream as well? > > https://github.com/godotengine/godot/pull/18348 Thanks.
> > Can you please patch drivers/unix/os_unix.cpp and SUBST_CMD it in > > post-patch? sed(1) might be the tool if you cannot avoid massive editing > > and want to avoid tons of patches for that, but in general I'd like to > > stop editing sources in place. > > Done, and works. sed is still used a lot in the ports tree. I guess your plan > is to weed this out over time? There's no strict plan, but patching is simply cleaner here imho. > > http://docs.godotengine.org/en/latest/development/compiling/compiling_for_x11.html > > says "Python 2.7+ (Python 3 only supported as of SCons 3.0)", our > > devel/scons is at 2.5.1, so you should set MODPY_VERSION accordingly. > > scons does use python2.7 during the build. Would it make sense to rather add > this to the devel/scons module? (cc'ing Maintainer) > It's only used a build time. This might be because Python 3 is not installed on your system. Explicitly setting the required version makes intention clear and avoids errors when building with autodetected versions. If devel/scons<=2.5.1 is limited to Python 2 this should obviously be set there instead of every port using it. > > scons has full support for out-of-tree builds and ports as big as Godot > > will benefit from it, can you look into enabling SEPARATE_BUILD? See > > http://www.scons.org/doc/2.5.0/HTML/scons-user/ch15.html . > > Enabling SEPARATE_BUILD alone doesn't achieve anything and the binary is still > built in WRKSRC. Yes, I noticed that. > thfr@e5570:/usr/ports$ fgrep -iR variant_dir * > thfr@e5570:/usr/ports$ > > There isn't a single example of using scons' variant directory tree in our > ports tree and the use is far from intuitive. > > The example in your link uses a modification to a single SConscript file to > achieve this. godot doesn't have an SConscript file, but several SCsub files. > If someone more familiar with scons knows how to set this up with variant_dir > (including platform names in the build directory names) scenario I'd be happy > to test. Unfortunately, I'm completely unfamiliar with scons, too. Brian, maybe you can help out? Either ways, SEPARATE_BUILD shouldn't block the import of Godot once the port is ready. We can still work on that later on.
