Thanks for the thorough review!

> Have you asked upstream to provide stable release assets?

https://github.com/godotengine/godot/issues/18347

> I couldn't find an issue or pull request referencing the clang 6 fixes
> in patches/patch-scene_gui_rich_text_label_cpp, current HEAD doesn't
> have them either. Can you bring up this issue upstream as well?

https://github.com/godotengine/godot/pull/18348

> Can you please patch drivers/unix/os_unix.cpp and SUBST_CMD it in
> post-patch? sed(1) might be the tool if you cannot avoid massive editing
> and want to avoid tons of patches for that, but in general I'd like to
> stop editing sources in place.

Done, and works. sed is still used a lot in the ports tree. I guess your plan
is to weed this out over time?

> http://docs.godotengine.org/en/latest/development/compiling/compiling_for_x11.html
> says "Python 2.7+ (Python 3 only supported as of SCons 3.0)", our
> devel/scons is at 2.5.1, so you should set MODPY_VERSION accordingly.

scons does use python2.7 during the build. Would it make sense to rather add
this to the devel/scons module? (cc'ing Maintainer)
It's only used a build time.

> scons has full support for out-of-tree builds and ports as big as Godot
> will benefit from it, can you look into enabling SEPARATE_BUILD? See
> http://www.scons.org/doc/2.5.0/HTML/scons-user/ch15.html .

Enabling SEPARATE_BUILD alone doesn't achieve anything and the binary is still
built in WRKSRC.

thfr@e5570:/usr/ports$ fgrep -iR variant_dir *
thfr@e5570:/usr/ports$

There isn't a single example of using scons' variant directory tree in our
ports tree and the use is far from intuitive.

The example in your link uses a modification to a single SConscript file to
achieve this. godot doesn't have an SConscript file, but several SCsub files.
If someone more familiar with scons knows how to set this up with variant_dir
(including platform names in the build directory names) scenario I'd be happy
to test.

Updated tarball attached. Tested this one briefly without noticing any issues.

Attachment: godot.tgz
Description: Binary data

Reply via email to