jacek-lewandowski commented on code in PR #2972:
URL: https://github.com/apache/cassandra/pull/2972#discussion_r1421284986
##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -589,12 +592,20 @@ public void startup(ICluster cluster)
//
org.apache.cassandra.distributed.impl.AbstractCluster.startup sets the
exception handler for the thread
// so extract it to populate ExecutorFactory.Global
ExecutorFactory.Global.tryUnsafeSet(new
ExecutorFactory.Default(Thread.currentThread().getContextClassLoader(), null,
Thread.getDefaultUncaughtExceptionHandler()));
+
+ assert
!FBUtilities.getReleaseVersionString().equals(FBUtilities.UNKNOWN_RELEASE_VERSION)
: "Unknown version";
+ assert !FBUtilities.getReleaseVersionString().isEmpty() :
"Empty version";
+ assert FBUtilities.getReleaseVersionString().contains(".") :
"Invalid version: " + FBUtilities.getReleaseVersionString();
Review Comment:
yes, it is that case. However, we don't expect version to be unknown when
starting the node - we could expect that for the version obtained through the
Gossiper but in this case we get that version from property file and if it is
unknown or missing, something wrong is going on and the node will fail anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
