ekaterinadimitrova2 commented on code in PR #2972:
URL: https://github.com/apache/cassandra/pull/2972#discussion_r1430741920
##########
src/java/org/apache/cassandra/utils/FBUtilities.java:
##########
@@ -435,8 +434,14 @@ public static String getReleaseVersionString()
{
JVMStabilityInspector.inspectThrowable(e);
logger.warn("Unable to load version.properties", e);
- return "debug version";
Review Comment:
This is a change of behavior - before, we were returning "`debug version`"
here, now we will return null which leads to `UNKNOWN_RELEASE_VERSION`.
Also, this is not a bug fix but an improvement, so we should not commit it
to 4.1, but only trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
