jacek-lewandowski commented on code in PR #2972:
URL: https://github.com/apache/cassandra/pull/2972#discussion_r1431612882
##########
src/java/org/apache/cassandra/utils/FBUtilities.java:
##########
@@ -435,8 +434,14 @@ public static String getReleaseVersionString()
{
JVMStabilityInspector.inspectThrowable(e);
logger.warn("Unable to load version.properties", e);
- return "debug version";
Review Comment:
"debug_version" is nowhere referred. Its history dates back to 2010 and
Cassandra 0.7!!! Non-null value was introduced to resolve some problems in IDE
(https://issues.apache.org/jira/browse/CASSANDRA-1272). There is no way that we
would run Cassandra without version.properties or in case it is unreadable.
Also moving this method may be the actual fix because it eliminates to code
path which led to the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
