ekaterinadimitrova2 commented on code in PR #2972:
URL: https://github.com/apache/cassandra/pull/2972#discussion_r1430698139
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -344,6 +346,11 @@ public enum CassandraRelevantProperties
*/
GOSSIP_SETTLE_POLL_SUCCESSES_REQUIRED("cassandra.gossip_settle_poll_success_required",
"3"),
+ CONSISTENT_RANGE_MOVEMENT("cassandra.consistent.rangemovement", "true"),
+
CONSISTENT_SIMULTANEOUS_MOVES_ALLOW("cassandra.consistent.simultaneousmoves.allow"),
+ REPLACE_ADDRESS("cassandra.replace_address"),
+ BROADCAST_INTERVAL_MS("cassandra.broadcast_interval_ms", "60000"),
Review Comment:
` I just followed what we have today in 4.1 - a bit of mess, variables are
defined but not used consistently.`
The story is different. The original ticket (CASSANDRA-15876) where
`CassandraRelevantProperties` was created added only those system properties
already added in the VT. Which other properties will be added to the class and
exposed to the VT was a matter of a follow-up ticket (CASSANDRA-17797). The
batch of added properties was used around the codebase (in case someone didn't
miss anything)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
