belliottsmith commented on code in PR #3664:
URL: https://github.com/apache/cassandra/pull/3664#discussion_r1834620976
##########
src/java/org/apache/cassandra/service/accord/AccordConfigurationService.java:
##########
@@ -381,7 +381,7 @@ public synchronized void onNodesRemoved(long epoch,
Topology current, Set<Node.I
private long[] nonCompletedEpochsBefore(long max)
Review Comment:
I don't think it is safe for this method to be called from an unsynchronised
block without itself being synchronised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
