belliottsmith commented on code in PR #3664:
URL: https://github.com/apache/cassandra/pull/3664#discussion_r1834619047
##########
src/java/org/apache/cassandra/service/accord/AccordConfigurationService.java:
##########
@@ -325,7 +325,7 @@ private void reportMetadata(ClusterMetadata metadata)
Stage.MISC.submit(() -> reportMetadataInternal(metadata));
}
- synchronized void reportMetadataInternal(ClusterMetadata metadata)
+ void reportMetadataInternal(ClusterMetadata metadata)
Review Comment:
shouldn't we be applying the same treatment to `reportMetadataInternal`? It
looks to invoke several callbacks while holding the monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
