dcapwell commented on code in PR #3664:
URL: https://github.com/apache/cassandra/pull/3664#discussion_r1835153961
##########
src/java/org/apache/cassandra/service/accord/AccordConfigurationService.java:
##########
@@ -325,7 +325,7 @@ private void reportMetadata(ClusterMetadata metadata)
Stage.MISC.submit(() -> reportMetadataInternal(metadata));
}
- synchronized void reportMetadataInternal(ClusterMetadata metadata)
+ void reportMetadataInternal(ClusterMetadata metadata)
Review Comment:
I just noticed something I didn't see when I wrote the logic
```
Topology current = isEmpty() ? Topology.EMPTY : currentTopology();
```
in the case I listed above (`[5, 6, 10]`) the gaps we are filling would be
for topologies in the past, so the `onNodesRemoved` doesn't make sense. Also,
*should* this step run if the epoch is further ahead? so if we see 12 before
`11` is received should we also call? the locking doesn't really change this
but think I need to flesh this part out more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
