dcapwell commented on code in PR #3664:
URL: https://github.com/apache/cassandra/pull/3664#discussion_r1835164229
##########
src/java/org/apache/cassandra/service/accord/AccordConfigurationService.java:
##########
@@ -325,7 +325,7 @@ private void reportMetadata(ClusterMetadata metadata)
Stage.MISC.submit(() -> reportMetadataInternal(metadata));
}
- synchronized void reportMetadataInternal(ClusterMetadata metadata)
+ void reportMetadataInternal(ClusterMetadata metadata)
Review Comment:
removed sync and fixed the race condition bug with onRemove checking... we
now wait for the epoch to be ack, then we compare against `epoch - 1`, this
will enforce only 1 epoch will trigger the remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
