nvharikrishna commented on code in PR #163:
URL: https://github.com/apache/cassandra-sidecar/pull/163#discussion_r1890276735
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/InstanceConfigurationImpl.java:
##########
@@ -92,9 +112,13 @@ public InstanceConfigurationImpl(int id,
this.id = id;
this.host = host;
this.port = port;
- this.dataDirs = Collections.unmodifiableList(dataDirs);
+ this.dataDirs = dataDirs == null ? null :
Collections.unmodifiableList(dataDirs);
Review Comment:
Not trying to fix anything actually :). Trying to initialize the member
variables in a single constructor. Earlier constructor initialized dataDirs
with null, but this constructor is wrapping dataDirs with
`Collections.unmodifiableList` which doesn't accept null. So checking for null
before wrapping it.
##########
server/src/test/java/org/apache/cassandra/sidecar/cluster/instance/InstanceMetadataImplTest.java:
##########
@@ -39,6 +39,10 @@ class InstanceMetadataImplTest
private static final String DATA_DIR_2 = "test/data/data2";
private static final String CDC_DIR = "cdc_dir";
private static final String STAGING_DIR = "staging_dir";
+ private static final String COMMITLOG_DIR = "commitlog";
Review Comment:
I have used the names used in cassandra.yaml for newly introduced
directories. Wanted to use default names used in Cassandra, but I don't mind
changing the names if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
