frankgh commented on code in PR #163:
URL: https://github.com/apache/cassandra-sidecar/pull/163#discussion_r1894326313
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/InstanceConfigurationImpl.java:
##########
@@ -92,9 +112,13 @@ public InstanceConfigurationImpl(int id,
this.id = id;
this.host = host;
this.port = port;
- this.dataDirs = Collections.unmodifiableList(dataDirs);
+ this.dataDirs = dataDirs == null ? null :
Collections.unmodifiableList(dataDirs);
Review Comment:
when would data dirs be null (or empty)? Maybe this needs to be validated
instead of accepting null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
