frankgh commented on code in PR #163:
URL: https://github.com/apache/cassandra-sidecar/pull/163#discussion_r1894327835
##########
server/src/test/java/org/apache/cassandra/sidecar/cluster/instance/InstanceMetadataImplTest.java:
##########
@@ -39,6 +39,10 @@ class InstanceMetadataImplTest
private static final String DATA_DIR_2 = "test/data/data2";
private static final String CDC_DIR = "cdc_dir";
private static final String STAGING_DIR = "staging_dir";
+ private static final String COMMITLOG_DIR = "commitlog";
Review Comment:
we should not, this is the default directory name for the commit log in
Cassandra, so it would be incorrect to add `_dir`. See
https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
