frankgh commented on code in PR #163:
URL: https://github.com/apache/cassandra-sidecar/pull/163#discussion_r1894324868
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/InstanceConfigurationImpl.java:
##########
@@ -64,17 +76,21 @@ public class InstanceConfigurationImpl implements
InstanceConfiguration
public InstanceConfigurationImpl()
{
- this.id = 0;
- this.host = null;
- this.port = 9042;
- this.dataDirs = null;
- this.stagingDir = null;
- this.cdcDir = null;
- this.jmxHost = null;
- this.jmxPort = 0;
- this.jmxSslEnabled = false;
- this.jmxRole = null;
- this.jmxRolePassword = null;
+ this(0,
+ null,
+ 9042,
+ null,
+ null,
+ null,
+ null,
Review Comment:
I agree that we should simplify Sidecar configuration, where we follow
Cassandra's configuration. Ideally, we will only have to configure the
`cassandra_home` configuration per instance. And then we resolve the directory
files in Cassandra unless explicitly provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
