dcapwell commented on code in PR #4222:
URL: https://github.com/apache/cassandra/pull/4222#discussion_r2192928535
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -550,12 +555,40 @@ else if (!clusterings.isEmpty())
}
}
break;
+ case RANGE:
+ LookupContext ctx = new LookupContext(delete);
+ for (BytesPartitionState.Row value : partition.rows())
+ {
+ if (ctx.include(value))
+ partition.deleteRow(value.clustering, nowTs);
+ }
+ break;
default:
throw new UnsupportedOperationException();
}
}
}
+ private boolean containsRangeCondition(List<Conditional> conditionals)
Review Comment:
this is "correct" in the sense it answers the question about the existence
of a range, but don't we only care about clustering columns in the only usage?
The lang doesn't really support delete value by range but the AST does (it can
test valid and not valid CQL).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
