dcapwell commented on code in PR #4222:
URL: https://github.com/apache/cassandra/pull/4222#discussion_r2193007363
##########
test/unit/org/apache/cassandra/utils/ASTGenerators.java:
##########
@@ -866,6 +869,68 @@ else if (existAllowed)
};
}
+ private enum rangeType {UNBOUD, BOUND , BETWEEN}
+ private static final Gen<Conditional.Where.Inequality>
RANGE_INEQUALITY_GEN =
SourceDSL.arbitrary().pick(Conditional.Where.Inequality.GREATER_THAN_EQ,
+
Conditional.Where.Inequality.GREATER_THAN,
+
Conditional.Where.Inequality.LESS_THAN_EQ,
+
Conditional.Where.Inequality.LESS_THAN);
+
+ private static final Gen<Conditional.Where.Inequality> LOWER_BOUND_GEN
= SourceDSL.arbitrary().pick(Conditional.Where.Inequality.GREATER_THAN,
+
Conditional.Where.Inequality.GREATER_THAN_EQ);
+
+ private static final Gen<Conditional.Where.Inequality> UPPER_BOUND_GEN
= SourceDSL.arbitrary().pick(Conditional.Where.Inequality.LESS_THAN,
+
Conditional.Where.Inequality.LESS_THAN_EQ);
+
+
+ private void valueRange(RandomnessSource rnd,
+ Map<Symbol, ExpressionBuilder>
columnExpressions,
+ Conditional.ConditionalBuilder<?> builder,
+ LinkedHashSet<Symbol> columns,
+ @Nullable Gen <? extends Map<Symbol, Object>>
gen)
+ {
+ if (gen == null)
+ throw new UnsupportedOperationException("TODO: add support
later... fine to ignore for now");
Review Comment:
```
Caused by: java.lang.UnsupportedOperationException: TODO: add support
later... fine to ignore for now
at
org.apache.cassandra.utils.ASTGenerators$MutationGenBuilder.valueRange(ASTGenerators.java:892)
at
org.apache.cassandra.utils.ASTGenerators$MutationGenBuilder.lambda$build$11(ASTGenerators.java:795)
at
org.apache.cassandra.utils.Generators.lambda$toGen$30(Generators.java:648)
at
org.apache.cassandra.distributed.test.cql3.StatefulASTBase.insert(StatefulASTBase.java:212)
```
guess it isn't =)
`org.apache.cassandra.distributed.test.cql3.FullAccordInteropMultiNodeTableWalkTest`
hit this
but assume that all the `*TableWalkTest` would
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
