dcapwell commented on code in PR #4222:
URL: https://github.com/apache/cassandra/pull/4222#discussion_r2192948631
##########
test/unit/org/apache/cassandra/utils/ASTGenerators.java:
##########
@@ -866,6 +869,68 @@ else if (existAllowed)
};
}
+ private enum rangeType {UNBOUD, BOUND , BETWEEN}
+ private static final Gen<Conditional.Where.Inequality>
RANGE_INEQUALITY_GEN =
SourceDSL.arbitrary().pick(Conditional.Where.Inequality.GREATER_THAN_EQ,
+
Conditional.Where.Inequality.GREATER_THAN,
+
Conditional.Where.Inequality.LESS_THAN_EQ,
+
Conditional.Where.Inequality.LESS_THAN);
+
+ private static final Gen<Conditional.Where.Inequality> LOWER_BOUND_GEN
= SourceDSL.arbitrary().pick(Conditional.Where.Inequality.GREATER_THAN,
+
Conditional.Where.Inequality.GREATER_THAN_EQ);
+
+ private static final Gen<Conditional.Where.Inequality> UPPER_BOUND_GEN
= SourceDSL.arbitrary().pick(Conditional.Where.Inequality.LESS_THAN,
+
Conditional.Where.Inequality.LESS_THAN_EQ);
+
+
+ private void valueRange(RandomnessSource rnd,
Review Comment:
there is a ton of duplication in the existing tests with regard to `SELECT`,
could you see how painful it would be to make this a reusable builder that the
tests can use?
`org.apache.cassandra.distributed.test.cql3.SingleNodeTableWalkTest#simpleRangeSearch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
