dcapwell commented on code in PR #4222:
URL: https://github.com/apache/cassandra/pull/4222#discussion_r2192934087
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -772,6 +805,7 @@ private Pair<List<Clustering<ByteBuffer>>,
List<Conditional>> splitOn(ImmutableU
// pk requires equality
Map<Symbol, List<ByteBuffer>> pks = new HashMap<>();
List<Conditional> other = new ArrayList<>();
+ Map<Symbol, List<Conditional.Where>> rangeConditions = new HashMap<>();
Review Comment:
Why are you trying to handle ranges in this method? we call this on
partition and if the partition has clustering ranges we then need to special
case it and not call `splitOn` for clustering. I think we can drop the changes
to this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
