JeetKunDoug commented on code in PR #4255:
URL: https://github.com/apache/cassandra/pull/4255#discussion_r2310306158
##########
src/java/org/apache/cassandra/profiler/AsyncProfilerMBean.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.cassandra.profiler;
+
+public interface AsyncProfilerMBean {
+ void start(String event, String outputFormat);
Review Comment:
I do like the `executeUnsafe` method... trying to wrap my head around having
a plain Map<String, String> for the options. Given JMX's limitations on using
any kind of custom type across calling boundaries unless the custom type exists
on both sides of the call, I can see it being a reasonable compromise as long
as we carefully curate the options allowed to prevent potential security issues
(like the output file issue you pointed out).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
