JeetKunDoug commented on code in PR #4255:
URL: https://github.com/apache/cassandra/pull/4255#discussion_r2387830828
##########
src/java/org/apache/cassandra/profiler/AsyncProfilerMBean.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.cassandra.profiler;
+
+public interface AsyncProfilerMBean {
+ void start(String event, String outputFormat);
+ void stop(String outputFile);
Review Comment:
I'd trust Jon on this - use the prop to specify the root directory, provide
a filename as an option, but default to the timestamped file if no output
filename is provided... just make sure you sanitize the input so we don't
introduce a path traversal issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
