rustyrazorblade commented on code in PR #4255:
URL: https://github.com/apache/cassandra/pull/4255#discussion_r2311341193
##########
src/java/org/apache/cassandra/profiler/AsyncProfilerMBean.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.cassandra.profiler;
+
+public interface AsyncProfilerMBean {
+ void start(String event, String outputFormat);
+ void stop(String outputFile);
Review Comment:
I think it would be better to keep outputFile and not allow the user to pick
arbitrary directories. I have profiling built into easy-cass-lab using
timestamps, and I end up losing track of which one correlated to what. I
regret having built it that way.
Without a custom filename, the artifacts quickly become meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
