JeetKunDoug commented on code in PR #4255:
URL: https://github.com/apache/cassandra/pull/4255#discussion_r2387840357
##########
src/java/org/apache/cassandra/profiler/AsyncProfilerMBean.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.cassandra.profiler;
+
+public interface AsyncProfilerMBean {
+ void start(String event, String outputFormat);
Review Comment:
So here's a different option - what if we have 2 mbeans, one for the "safe"
endpoint and another for the "unsafe" - that way, people who, for some
environmental reasons, really don't want the unsafe version in their system can
just delete the implementation .class file (or we could have a build option to
include/exclude it, but I think that may be a pain). This would allow for
someone to deploy a version of Cassandra that literally could not run the
`executeUnsafe` if they didn't want it available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
