On Thu, Jul 11, 2013 at 3:49 PM, Matthew Burgess < [email protected]> wrote:
> On 11 July 2013 20:28, Dan White <[email protected]> wrote: > >> Excellent. I will see what I can do to contribute a run-it-by-cron >> option to the module, since I already do that. >> >> As far as the large time differences, there are multiple references "out >> there" to a line at the top of ntp.conf as follows: >> >> tinker panic 0 >> > > That line's actually *required* on VM guests (see > http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1006427 > - search for 'NTP Recommendations' > ). The templates could use updating to guard it with '<% if @panic == > false || @is_virtual == true -%>' instead of just the single @panic check > that they currently have > . Or does it perhaps need to be a little more complex so that a warning > can be spat out if the conflicting options of @panic == true and > @is_virtual == true are set for a particular guest? > In the new code we set panic based on $is_virtual by default, so it sets panic to false for virtual and true for physical. That way we get the right behavior out of the box and physical people can override it too. I figured that was preferable to having more logic in the templates. I suppose it depends on if there is the potential of a use case where people on virtual machines are simply not allowed to tolerate large skews either, I'd hate to railroad them by forcing the issue. -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
