On Sun, Sep 25, 2011 at 11:57 AM, Mac Ryan <[email protected]> wrote:
> On Sun, 25 Sep 2011 14:18:25 +1300 > Greg Ewing <[email protected]> wrote: > > > Mac Ryan wrote: > > > > > The behaviour that I envisage would be an > > > optional keyword argument ``scale=1.0`` for rectangles (and > > > surfaces). > > > > I would say the transformation should be an attribute of the > > surface, not something that you pass into drawing calls. > > But isn't this what I just say? Or did I misunderstand you? Or did you > misunderstand me? :o > > On Sun, 25 Sep 2011 09:55:20 +0200 > René Dudfield <[email protected]> wrote: > > > Could you create a transform rect like function that returns the > > transformed state? > > > > >>> t(20, 20, 20, 20) > > (1,1,1,1) > > That's exactly what I have at the moment (mine is called ``sc()``, but > that's irrelevant... :)). > > I still think that's a "missing battery" thing though. I haven't > browsed much into code of games on pygame.org, but I wouldn't be > astonished if a large portion (probably even the majority) of the code > would internally use a non-scaled model, to be transformed at > representation time... > > Anyhow: not a big issue, it's just that is not an uncommon feature in > other libraries and I feel that inserting it in pygame would make > pygame better, but I *can* live without. :) > > /mac > It's a feature I've used on apps myself, but differently for a number of them. There's a million different transforms that you could do. From scaling, to shearing to rotation, to random quaternions or matrices. I guess you could add an optional transform matrix for every coordinate, or rect and that would work for most cases. I still think a transforming Rect subclass would work best, like your 'sc' function. Otherwise you'd need global state, which is always something pygame tries to avoid. An automatically generated wrapper which transforms any rect, or coord like args could be possible to make... # untested wrapper maker. def transform_rect_like(r): if type(s) in []: #TODO... do rect like detection and return a transformed thing. pass def transform(*args): return tuple([transform_rect_like(a) for a in args]) def transform_kw(*kwargs): return dict([(k, transform_rect_like(v)) for k,v in kwargs.items()]) def make_wrapper(mod, into_obj): for k, f in mod.__dict__.items(): def wrapped_f(*args, **kwargs): return f(*transform(args), **transformkw(kwargs)) setattr(into_mod, k, wrapped_f) make_wrapper(pygame.draw, mydraw) Maybe it would be possible to implement easily in C, without too much code, but maybe not. I'm not interested in it myself, since I think it's not too hard to layer on top - so I won't spend any effort implementing it. However, if you want to submit a patch that doesn't make the code super ugly, and doesn't cost too much performance we could add it. cheers,
