On Wed, 15 Mar 2017 at 08:44 Berker Peksağ <berker.pek...@gmail.com> wrote:
> On Mon, Mar 13, 2017 at 12:11 AM, Brett Cannon <br...@python.org> wrote: > > > > > > On Sun, 12 Mar 2017 at 06:33 M.-A. Lemburg <m...@egenix.com> wrote: > >> > >> On 10.03.2017 23:13, Brett Cannon wrote: > >> > Fifth, anything I missed? :) > >> > >> My main nit after the move is that messages to the checkin list > >> no longer include the full patch. This makes reviews harder than > >> necessary (you always have to go through the browser). > >> > >> Is there some way this could be changed back to what we had > >> previously or is this a hard limitation of github ? > > > > > > It's a hard limitation of the GitHub-provided email solution. With > GitHub's > > APIs and enough time someone could either come up with a custom email > > solution or a web page that showed this information (you literally just > need > > to add ".diff" to the end of a URL to get the diff itself for a PR, e.g. > > https://github.com/python/cpython/pull/648.diff will redirect to a raw > > diff). There might also already be other solutions out there that do what > > you're after. > > > > Obviously this all requires work on someone's part. :) (I've also moved > > completely off of an email-based workflow so I'm definitely not the right > > person to drive this sort of thing.) > > I wrote https://github.com/berkerpeksag/cpython-emailer-webhook to > solve this problem. It works and its output is almost same as the old > one [1] I even wrote some tests and documentation, but I just noticed > that I forgot to push to GitHub :) > > If we all agree on the idea I can help with deploying it. I can use my > own VPS for the initial deploy, but it would be nice to have a PSF > backed server in the long term. > I believe we have free Heroku resources to putting it there should be easy (the infrastructure team would know best obviously where we have free resources). -Brett > > --Berker > > [1] > https://github.com/python/core-workflow/issues/24#issuecomment-279162079 >
_______________________________________________ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/